chore: upgrade all devDependencies and migrate to eslint 10 flat config

- Upgrade eslint 8.31 → 10.1 with new flat config (eslint.config.js)
- Upgrade @vercel/ncc 0.36 → 0.38.4
- Replace eslint-config-airbnb-base + eslint-plugin-import with @eslint/js + @stylistic/eslint-plugin
- Remove stale overrides (word-wrap, semver) that patched eslint 8 transitive deps
- Remove obsolete eslint-disable comments from source files
- Add { cause } to rethrown error in rsyncCli.js
- Resolves all 3 npm audit vulnerabilities (flatted, minimatch, js-yaml)

.eslintrc.js

@@ -1,25 +0,0 @@
-module.exports = {
-  env: {
-    commonjs: true,
-    es6: true,
-    node: true
-  },
-  extends: [
-    'airbnb-base'
-  ],
-  globals: {
-    Atomics: 'readonly',
-    SharedArrayBuffer: 'readonly'
-  },
-  parserOptions: {
-    ecmaVersion: 2018
-  },
-  rules: {
-    'comma-dangle': [
-      'error',
-      'never'
-    ],
-    'no-console': 'off',
-    'object-curly-newline': 'off'
-  }
-};

.github/workflows/build.yml

@@ -18,9 +18,9 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Setup Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install dependencies

.github/workflows/codeql-analysis.yml

@@ -31,11 +31,11 @@ jobs:
         language: [ 'javascript' ]
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3
+      uses: github/codeql-action/init@v4
       with:
         languages: ${{ matrix.language }}
 
@@ -44,4 +44,4 @@ jobs:
         npm run build --if-present
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3
+      uses: github/codeql-action/analyze@v4

.github/workflows/e2e-manual.yml

@@ -27,7 +27,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
 #         ----------------------------------------------------------------
 #         START E2E Test Specific - steps

.github/workflows/e2e.yml

@@ -15,7 +15,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
 #         : ---------------------------------------------------------------
 #         : START E2E Test Specific - steps
@@ -111,7 +111,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       #         : ---------------------------------------------------------------
       #         : START E2E Test Specific - steps

.github/workflows/manual-release.yml

@@ -49,9 +49,9 @@ jobs:
 
     steps:
       - name: Checkout repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Setup Node.js ${{ matrix.NODE_VERSION }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.NODE_VERSION }}
       - name: Commit trigger
@@ -64,8 +64,9 @@ jobs:
       - name: Run Tests
         run: npm test --if-present
       - name: Create a release - ${{ github.event.inputs.version }}
-        uses: cycjimmy/semantic-release-action@v4
+        uses: cycjimmy/semantic-release-action@v6
         with:
+          semantic_version: 24
           dry_run: ${{ github.event.inputs.dryRun == 'true' }}
           extra_plugins: |
             @semantic-release/changelog

.github/workflows/release.yml

@@ -16,9 +16,9 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix['node-version'] }}
       - name: Install dependencies
@@ -28,8 +28,9 @@ jobs:
       - name: Run Tests
         run: npm test --if-present
       - name: Release
-        uses: cycjimmy/semantic-release-action@v4
+        uses: cycjimmy/semantic-release-action@v6
         with:
+          semantic_version: 24
           dry_run: false
           extra_plugins: |
             @semantic-release/changelog

.github/workflows/update-major-tag.yml

@@ -0,0 +1,23 @@
+name: Update major version tag
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  update-tag:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+
+    steps:
+      - uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+      - name: Update major version tag
+        run: |
+          VERSION="${{ github.event.release.tag_name }}"
+          MAJOR="v$(echo "$VERSION" | sed 's/^v//' | cut -d. -f1)"
+          echo "Updating $MAJOR tag to point to $VERSION"
+          git tag -f "$MAJOR" "$VERSION"
+          git push -f origin "$MAJOR"

eslint.config.js

@@ -0,0 +1,52 @@
+const js = require('@eslint/js');
+const stylistic = require('@stylistic/eslint-plugin');
+const globals = require('globals');
+
+module.exports = [
+  js.configs.recommended,
+  {
+    plugins: {
+      '@stylistic': stylistic
+    },
+    languageOptions: {
+      ecmaVersion: 2020,
+      sourceType: 'commonjs',
+      globals: {
+        ...globals.node,
+        ...globals.commonjs,
+        ...globals.es2020,
+        Atomics: 'readonly',
+        SharedArrayBuffer: 'readonly'
+      }
+    },
+    rules: {
+      // Stylistic rules (migrated from airbnb-base)
+      '@stylistic/comma-dangle': ['error', 'never'],
+      '@stylistic/indent': ['error', 2, { SwitchCase: 1 }],
+      '@stylistic/semi': ['error', 'always'],
+      '@stylistic/quotes': ['error', 'single', { avoidEscape: true }],
+      '@stylistic/arrow-parens': ['error', 'always'],
+      '@stylistic/brace-style': ['error', '1tbs', { allowSingleLine: true }],
+      '@stylistic/comma-spacing': ['error', { before: false, after: true }],
+      '@stylistic/key-spacing': ['error', { beforeColon: false, afterColon: true }],
+      '@stylistic/keyword-spacing': ['error', { before: true, after: true }],
+      '@stylistic/eol-last': ['error', 'always'],
+      '@stylistic/no-trailing-spaces': 'error',
+      '@stylistic/space-before-blocks': 'error',
+      '@stylistic/space-infix-ops': 'error',
+      '@stylistic/arrow-spacing': ['error', { before: true, after: true }],
+
+      // JS rules (migrated from airbnb-base)
+      'no-console': 'off',
+      'no-var': 'error',
+      'prefer-const': 'error',
+      'prefer-arrow-callback': 'error',
+      'prefer-template': 'error',
+      'object-shorthand': ['error', 'always'],
+      'no-shadow': 'error',
+      'no-use-before-define': ['error', { functions: true, classes: true, variables: true }],
+      'camelcase': ['error', { properties: 'never' }],
+      'no-unused-vars': ['error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true }]
+    }
+  }
+];

package.json

@@ -29,17 +29,11 @@
     "url": "https://github.com/easingthemes/ssh-deploy/issues"
   },
   "homepage": "https://github.com/easingthemes/ssh-deploy#readme",
-  "dependencies": {
-    "rsyncwrapper": "^3.0.1"
-  },
   "devDependencies": {
-    "@vercel/ncc": "^0.36.0",
+    "@eslint/js": "^10.0.1",
-    "eslint": "^8.30.0",
+    "@stylistic/eslint-plugin": "^5.10.0",
-    "eslint-config-airbnb-base": "^15.0.0",
+    "@vercel/ncc": "^0.38.4",
-    "eslint-plugin-import": "^2.26.0"
+    "eslint": "^10.1.0",
-  },
+    "globals": "^17.4.0"
-  "overrides": {
-    "word-wrap": "npm:@aashutoshrathi/word-wrap@1.2.5",
-    "semver": "^7.5.2"
   }
 }

src/index.js

@@ -27,7 +27,6 @@ const run = async () => {
   if (scriptBefore) {
     await remoteCmdBefore(scriptBefore, privateKeyPath, scriptBeforeRequired);
   }
-  /* eslint-disable object-property-newline */
   await sshDeploy({
     source, rsyncServer, exclude, remotePort,
     privateKeyPath, args, sshCmdArgs

src/inputs.js

@@ -27,7 +27,6 @@ inputNames.forEach((input) => {
   const inputVal = process.env[input] || process.env[`INPUT_${input}`] || defaultInputs[inputName];
   const validVal = inputVal === undefined ? defaultInputs[inputName] : inputVal;
   let extendedVal = validVal;
-  // eslint-disable-next-line default-case
   switch (inputName) {
     case 'source':
       extendedVal = validVal.split(' ').map((src) => `${githubWorkspace}/${src}`);

src/remoteCmd.js

@@ -11,7 +11,6 @@ const handleError = (message, isRequired, callback) => {
   }
 };
 
-// eslint-disable-next-line max-len
 const remoteCmd = async (content, privateKeyPath, isRequired, label) => new Promise((resolve, reject) => {
   const uuid = crypto.randomUUID();
   const filename = `local_ssh_script-${label}-${uuid}.sh`;

src/rsync.js

@@ -0,0 +1,56 @@
+const { spawn } = require('child_process');
+
+const escapeSpaces = (str) => (typeof str === 'string' ? str.replace(/\b\s/g, '\\ ') : str);
+
+const buildRsyncCommand = ({ src, dest, excludeFirst, port, privateKey, args, sshCmdArgs }) => {
+  const cmdParts = [];
+
+  const sources = Array.isArray(src) ? src : [src];
+  cmdParts.push(...sources.map(escapeSpaces));
+  cmdParts.push(escapeSpaces(dest));
+
+  let sshCmd = `ssh -p ${port || 22} -i ${privateKey}`;
+  if (sshCmdArgs && sshCmdArgs.length > 0) {
+    sshCmd += ` ${sshCmdArgs.join(' ')}`;
+  }
+  cmdParts.push('--rsh', `"${sshCmd}"`);
+
+  cmdParts.push('--recursive');
+
+  if (Array.isArray(excludeFirst)) {
+    excludeFirst.forEach((pattern) => {
+      if (pattern) cmdParts.push(`--exclude=${escapeSpaces(pattern)}`);
+    });
+  }
+
+  if (Array.isArray(args)) {
+    cmdParts.push(...args);
+  }
+
+  return `rsync ${[...new Set(cmdParts)].join(' ')}`;
+};
+
+module.exports = (options, callback) => {
+  const cmd = buildRsyncCommand(options);
+  const noop = () => {};
+  const onStdout = options.onStdout || noop;
+  const onStderr = options.onStderr || noop;
+
+  let stdout = '';
+  let stderr = '';
+  const proc = spawn('/bin/sh', ['-c', cmd]);
+
+  proc.stdout.on('data', (data) => { onStdout(data); stdout += data; });
+  proc.stderr.on('data', (data) => { onStderr(data); stderr += data; });
+
+  proc.on('exit', (code) => {
+    let error = null;
+    if (code !== 0) {
+      error = new Error(`rsync exited with code ${code}`);
+      error.code = code;
+    }
+    callback(error, stdout, stderr, cmd);
+  });
+
+  proc.on('error', (err) => callback(err, stdout, stderr, cmd));
+};

src/rsyncCli.js

@@ -1,5 +1,5 @@
 const { execSync } = require('child_process');
-const nodeRsync = require('rsyncwrapper');
+const nodeRsync = require('./rsync');
 
 const nodeRsyncPromise = async (config) => new Promise((resolve, reject) => {
   const logCMD = (cmd) => {
@@ -46,7 +46,7 @@ const validateRsync = async () => {
     execSync('sudo DEBIAN_FRONTEND=noninteractive apt-get -y update && sudo DEBIAN_FRONTEND=noninteractive apt-get --no-install-recommends -y install rsync', { stdio: 'inherit' });
     console.log('✅ [CLI] Rsync installed. \n');
   } catch (error) {
-    throw new Error(`⚠️ [CLI] Rsync installation failed. Aborting ... error: ${error.message}`);
+    throw new Error(`⚠️ [CLI] Rsync installation failed. Aborting ... error: ${error.message}`, { cause: error });
   }
 };
 
@@ -65,7 +65,6 @@ const rsyncCli = async ({
   };
 
   // RSYNC COMMAND
-  /* eslint-disable object-property-newline */
   return nodeRsyncPromise({
     ...defaultOptions,
     src: source, dest: rsyncServer, excludeFirst: exclude, port: remotePort,