heibai2006/web3.php
1
0
Fork 0
Code Issues Pull Requests Projects Releases 2 Wiki Activity

Fix: method validation in both send and call

Browse Source 
Making sure method is a string and it exists under functions

I was trying to call a nonexistent method. Since I passed a string it went through without checking if it exists as a function or not

This commit fixes that by changing `&&` to `||` (or)
This commit is contained in:
Arul 2018-06-07 18:02:08 +08:00 committed by GitHub
parent be7403a00b
commit 3d8a567054
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Contract.php
View File

@ -422,8 +422,8 @@ class Contract
$method = array_splice($arguments, 0, 1)[0]; $method = array_splice($arguments, 0, 1)[0];
$callback = array_pop($arguments); $callback = array_pop($arguments);
if (!is_string($method) && !isset($this->functions[$method])) { if (!is_string($method) || !isset($this->functions[$method])) {
throw new InvalidArgumentException('Please make sure the method is existed.'); throw new InvalidArgumentException('Please make sure the method exists.');
} }
$function = $this->functions[$method]; $function = $this->functions[$method];
@ -468,8 +468,8 @@ class Contract
$method = array_splice($arguments, 0, 1)[0]; $method = array_splice($arguments, 0, 1)[0];
$callback = array_pop($arguments); $callback = array_pop($arguments);
if (!is_string($method) && !isset($this->functions[$method])) { if (!is_string($method) || !isset($this->functions[$method])) {
throw new InvalidArgumentException('Please make sure the method is existed.'); throw new InvalidArgumentException('Please make sure the method exists.');
} }
$function = $this->functions[$method]; $function = $this->functions[$method];
@ -621,4 +621,4 @@ class Contract
return $functionData; return $functionData;
} }
} }
} }